Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle case of invalid package.json with no explicit config #5198

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: handle case of invalid package.json with no explicit config #5198

wants to merge 5 commits into from

Commits on Aug 14, 2024

  1. fix: report syntax errors in package.json (fixes: mochajs#5141)

    @dhdaines
    dhdaines committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6d8e90d View commit details
    Browse the repository at this point in the history

  2. fix(tests): incorrect test (should use existing result) 

    Since `readFileSync` is only stubbed `onFirstCall` we get a different answer
the second time around which is probably Not What You Want.  But also we
*already checked that config = false*.  So you could just remove this
test, it does nothing useful.
    @dhdaines
    dhdaines committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f1fe344 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. fix: separate read and parse errors

    @dhdaines
    dhdaines committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a7f015a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. fix: clarify invalid JSON 

    Co-authored-by: Josh Goldberg ✨ <[email protected]>
    @dhdaines @JoshuaKGoldberg
    dhdaines and JoshuaKGoldberg authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8c4103f View commit details
    Browse the repository at this point in the history

  2. fix(test): expect only a SyntaxError nothing else

    @dhdaines
    dhdaines committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cd33f01 View commit details
    Browse the repository at this point in the history