Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-enable tests using the beta channel #980

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 28, 2023

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

I removed tests using the beta channel in #907. This PR reverts it.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit b28aeaa
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/65901903a386e50008487144

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41f55df) 99.01% compared to head (0b8418d) 99.01%.
Report is 1 commits behind head on main.

❗ Current head 0b8418d differs from pull request most recent head b28aeaa. Consider uploading reports for the commit b28aeaa to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          57       57           
  Lines        2024     2024           
=======================================
  Hits         2004     2004           
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.56% <ø> (ø)
mobx_codegen 100.00% <ø> (ø)
mobx_lint ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f55df...b28aeaa. Read the comment docs.

@amondnet amondnet self-assigned this Dec 28, 2023
@amondnet amondnet requested a review from pavanpodila December 28, 2023 05:51
@pavanpodila pavanpodila merged commit 0f1c2ca into mobxjs:main Dec 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants