-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-844 #894
gh-844 #894
Conversation
…stem for performance
…n be properly disposed mobxjs#857
merge from upstream
This reverts commit 63d57ef.
This reverts commit 20fe5d3.
This reverts commit 263155b. # Conflicts: # mobx/test/computed_test.dart
…alues can be properly disposed mobxjs#857" This reverts commit bbd9020.
Allow users to bypass observability system for performance; Avoid unnecessary observable notifications of @observable fields of Stores; Fix Reaction lacks toString, so cannot see which reaction causes the error; Add StackTrace to reactions in debug mode to easily spot which reaction it is
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 98.95% 98.97% +0.01%
==========================================
Files 55 55
Lines 1922 1943 +21
==========================================
+ Hits 1902 1923 +21
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Describe the changes proposed in this Pull Request.
close #844
close #857
close #858
close #859
close #855
close #864
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelo run set_version
command from the root directory