-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eegbci api: allow downloading multiple subjects #12918
Open
sappelhoff
wants to merge
5
commits into
mne-tools:main
Choose a base branch
from
sappelhoff:eegbci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
541172a
eegbci api: allow downloading multiple subjects
sappelhoff 5fcb302
add links to eegbci metadata docs
sappelhoff cd1e2f2
properly deprecate and add test
sappelhoff aaae8ff
update tutorials
sappelhoff b948724
add changelog
sappelhoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,9 @@ | |
|
||
See https://en.wikipedia.org/wiki/Common_spatial_pattern and | ||
:footcite:`Koles1991`. The EEGBCI dataset is documented in | ||
:footcite:`SchalkEtAl2004` and is available at PhysioNet | ||
:footcite:`GoldbergerEtAl2000`. | ||
:footcite:`SchalkEtAl2004` and on the | ||
`PhysioNet documentation page <https://physionet.org/content/eegmmidb/1.0.0/>`_. | ||
The dataset is available at PhysioNet :footcite:`GoldbergerEtAl2000`. | ||
""" | ||
# Authors: Martin Billinger <[email protected]> | ||
# | ||
|
@@ -48,7 +49,7 @@ | |
eegbci.standardize(raw) # set channel names | ||
montage = make_standard_montage("standard_1005") | ||
raw.set_montage(montage) | ||
raw.annotations.rename(dict(T1="hands", T2="feet")) | ||
raw.annotations.rename(dict(T1="hands", T2="feet")) # as documented on PhysioNet | ||
raw.set_eeg_reference(projection=True) | ||
|
||
# Apply band-pass filter | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this I'd be tempted just to live with the misnomer
subject=[...]
rather than switch tosubjects=[...]
but the deprecation also won't be so terrible:And then you'll need to ensure that
subjects
andruns
are not None, i.e., the user has actually supplied values for them (raise an error if None). Then once deprecation is complete we can remove the=None
defaults safely.