Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new cluster test API #12663

Draft
wants to merge 99 commits into
base: main
Choose a base branch
from
Draft

new cluster test API #12663

wants to merge 99 commits into from
+747 −62

Commits on Jun 14, 2024

  1. added cluster test api, first commit

    @CarinaFo
    CarinaFo committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    62daaf0 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    d59978f View commit details
    Browse the repository at this point in the history

  3. tested dataframe function and results, cleaned up

    @CarinaFo
    CarinaFo committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2843905 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'new_cluster_stats_api_GSOC24' of https://github.com/Car… 

    …inaFo/mne-python into new_cluster_stats_api_GSOC24
    @CarinaFo
    CarinaFo committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1985da3 View commit details
    Browse the repository at this point in the history

  5. added ToDos

    @CarinaFo
    CarinaFo committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fa5b215 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    1a1511d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'new_cluster_stats_api_GSOC24' of https://github.com/Car… 

    …inaFo/mne-python into new_cluster_stats_api_GSOC24
    @CarinaFo
    CarinaFo committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    0ea220c View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a12cf95 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'mne-tools:main' into new_cluster_stats_api_GSOC24

    @CarinaFo
    CarinaFo authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3c5d4f1 View commit details
    Browse the repository at this point in the history

  2. added formula support and implemented suggestions

    @CarinaFo
    CarinaFo committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    45ce63a View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2b7bae8 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. fixed linting errors

    @CarinaFo
    CarinaFo committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    38834ba View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. ENH: Add dataset [skip azp] [skip actions]

    @larsoner
    larsoner committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c00859f View commit details
    Browse the repository at this point in the history

  2. FIX: One more [skip azp] [skip actions]

    @larsoner
    larsoner committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9c8ec90 View commit details
    Browse the repository at this point in the history

  3. FIX: Title [skip azp] [skip actions]

    @larsoner
    larsoner committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    47363b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. first draft of formulaic paired t-test

    @CarinaFo
    CarinaFo committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    1f6221d View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. first draft without cluster plotting class implemented

    @CarinaFo
    CarinaFo committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    37616e5 View commit details
    Browse the repository at this point in the history

  2. cleaned up plotting function

    @CarinaFo
    CarinaFo committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6aaef9a View commit details
    Browse the repository at this point in the history

  3. implemented cluser results class

    @CarinaFo
    CarinaFo committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0f99c70 View commit details
    Browse the repository at this point in the history

  4. added contribution

    @CarinaFo
    CarinaFo committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    4083691 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'mne-tools:main' into new_cluster_stats_api_GSOC24

    @CarinaFo
    CarinaFo authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    42d70f9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'new_cluster_stats_api_GSOC24' of https://github.com/Car… 

    …inaFo/mne-python into new_cluster_stats_api_GSOC24
    @CarinaFo
    CarinaFo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8a57215 View commit details
    Browse the repository at this point in the history

  3. fixed codespell

    @CarinaFo
    CarinaFo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7e9b2e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'main' into new_cluster_stats_api_GSOC24

    @CarinaFo
    CarinaFo authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    12f27dd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. first review

    @CarinaFo
    CarinaFo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8f510a9 View commit details
    Browse the repository at this point in the history

  2. quick clean up

    @CarinaFo
    CarinaFo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d6c0c4c View commit details
    Browse the repository at this point in the history

  3. test compare_old_vs_new_cluster_API

    @CarinaFo
    CarinaFo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f17f38f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. simplify tests 

    Co-authored-by: Carina Forster <[email protected]>
    @drammock @CarinaFo
    drammock and CarinaFo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9d592de View commit details
    Browse the repository at this point in the history

  2. refactor cluster_test 

    Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Carina Forster <[email protected]>
    @drammock @larsoner @CarinaFo
    3 people committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d64ef84 View commit details
    Browse the repository at this point in the history

  3. make tutorial match modified API 

    Co-authored-by: Carina Forster <[email protected]>
    @drammock @CarinaFo
    drammock and CarinaFo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    dc8a799 View commit details
    Browse the repository at this point in the history

  4. remove unused test helper func

    @drammock
    drammock committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f12cf6e View commit details
    Browse the repository at this point in the history

  5. vulture allowlist update

    @drammock
    drammock committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5b97971 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. included BaseTFR in validate_cluster_df

    @CarinaFo
    CarinaFo committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    5f5b0fc View commit details
    Browse the repository at this point in the history

  2. comments on cluster_test function

    @CarinaFo
    CarinaFo committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ccccb5b View commit details
    Browse the repository at this point in the history

  3. updated clusterResult class and plot function

    @CarinaFo
    CarinaFo committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    59b1a3a View commit details
    Browse the repository at this point in the history

  4. updated function call for plotting

    @CarinaFo
    CarinaFo committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    98d0879 View commit details
    Browse the repository at this point in the history

  5. changed color

    @CarinaFo
    CarinaFo committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ec03242 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'main' into new_cluster_stats_api_GSOC24

    @CarinaFo
    CarinaFo authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a513518 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'new_cluster_stats_api_GSOC24' of https://github.com/Car… 

    …inaFo/mne-python into new_cluster_stats_api_GSOC24
    @CarinaFo
    CarinaFo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1a5dd9d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. docstring/docdict cleanups and fixes

    @drammock
    drammock committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5941f61 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. implemented Dan's comments

    @CarinaFo
    CarinaFo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    368fa44 View commit details
    Browse the repository at this point in the history

  2. implemented Dan's comments

    @CarinaFo
    CarinaFo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3aa32b6 View commit details
    Browse the repository at this point in the history

  3. test for handling different MNE objects - test is failing

    @CarinaFo
    CarinaFo committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    a76afd3 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. adjusted test to account for multiple subjects

    @CarinaFo
    CarinaFo committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b5fce8b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. refactor df validation to return bools

    @drammock
    drammock committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    3ce510c View commit details
    Browse the repository at this point in the history

  2. unrelated typing fix

    @drammock
    drammock committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    feb1911 View commit details
    Browse the repository at this point in the history

  3. rework test

    @drammock
    drammock committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    6f97811 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. minor cleanup

    @drammock
    drammock committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b09d20a View commit details
    Browse the repository at this point in the history

  2. fix imports

    @drammock
    drammock committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    977e153 View commit details
    Browse the repository at this point in the history

  3. use MRO in test too

    @drammock
    drammock committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a288d85 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge pull request #5 from drammock/new_cluster_stats_api_GSOC24 

    fixes for test
    @CarinaFo
    CarinaFo authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    81ce0d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. added cluster test api, first commit

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    05586c8 View commit details
    Browse the repository at this point in the history

  2. tested dataframe function and results, cleaned up

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e8770fd View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @drammock
    pre-commit-ci[bot] authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a081d7d View commit details
    Browse the repository at this point in the history

  4. added ToDos

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d6d70c8 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @drammock
    pre-commit-ci[bot] authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8345261 View commit details
    Browse the repository at this point in the history

  6. added formula support and implemented suggestions

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0373195 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @drammock
    pre-commit-ci[bot] authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8bc44f9 View commit details
    Browse the repository at this point in the history

  8. fixed linting errors

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    654a350 View commit details
    Browse the repository at this point in the history

  9. ENH: Add dataset [skip azp] [skip actions]

    @larsoner @drammock
    larsoner authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d1ed8a1 View commit details
    Browse the repository at this point in the history

  10. FIX: One more [skip azp] [skip actions]

    @larsoner @drammock
    larsoner authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c634a44 View commit details
    Browse the repository at this point in the history

  11. FIX: Title [skip azp] [skip actions]

    @larsoner @drammock
    larsoner authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0c2eb4f View commit details
    Browse the repository at this point in the history

  12. first draft of formulaic paired t-test

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f46a79c View commit details
    Browse the repository at this point in the history

  13. first draft without cluster plotting class implemented

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5d1cbae View commit details
    Browse the repository at this point in the history

  14. cleaned up plotting function

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    268d0cf View commit details
    Browse the repository at this point in the history

  15. implemented cluser results class

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2f722bd View commit details
    Browse the repository at this point in the history

  16. fixed codespell

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fb75cfd View commit details
    Browse the repository at this point in the history

  17. first review

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a87ffed View commit details
    Browse the repository at this point in the history

  18. quick clean up

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1f857ad View commit details
    Browse the repository at this point in the history

  19. test compare_old_vs_new_cluster_API

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    450738b View commit details
    Browse the repository at this point in the history

  20. simplify tests 

    Co-authored-by: Carina Forster <[email protected]>
    @drammock @CarinaFo
    drammock and CarinaFo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d41efbe View commit details
    Browse the repository at this point in the history

  21. refactor cluster_test 

    Co-authored-by: Eric Larson <[email protected]>
Co-authored-by: Carina Forster <[email protected]>
    @drammock @larsoner @CarinaFo
    3 people committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9523fae View commit details
    Browse the repository at this point in the history

  22. make tutorial match modified API 

    Co-authored-by: Carina Forster <[email protected]>
    @drammock @CarinaFo
    drammock and CarinaFo committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9661492 View commit details
    Browse the repository at this point in the history

  23. remove unused test helper func

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    cac0559 View commit details
    Browse the repository at this point in the history

  24. vulture allowlist update

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    47ac838 View commit details
    Browse the repository at this point in the history

  25. included BaseTFR in validate_cluster_df

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    033c158 View commit details
    Browse the repository at this point in the history

  26. comments on cluster_test function

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2c2f341 View commit details
    Browse the repository at this point in the history

  27. updated clusterResult class and plot function

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e9b5fa2 View commit details
    Browse the repository at this point in the history

  28. updated function call for plotting

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2fd17d3 View commit details
    Browse the repository at this point in the history

  29. changed color

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    150c530 View commit details
    Browse the repository at this point in the history

  30. docstring/docdict cleanups and fixes

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3cc9e2c View commit details
    Browse the repository at this point in the history

  31. implemented Dan's comments

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2c27a69 View commit details
    Browse the repository at this point in the history

  32. implemented Dan's comments

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2664ee2 View commit details
    Browse the repository at this point in the history

  33. test for handling different MNE objects - test is failing

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4927544 View commit details
    Browse the repository at this point in the history

  34. adjusted test to account for multiple subjects

    @CarinaFo @drammock
    CarinaFo authored and drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    006acdf View commit details
    Browse the repository at this point in the history

  35. refactor df validation to return bools

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f0f4cba View commit details
    Browse the repository at this point in the history

  36. unrelated typing fix

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    346e3ce View commit details
    Browse the repository at this point in the history

  37. rework test

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a49d2cd View commit details
    Browse the repository at this point in the history

  38. minor cleanup

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a01182b View commit details
    Browse the repository at this point in the history

  39. fix imports

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0984b61 View commit details
    Browse the repository at this point in the history

  40. use MRO in test too

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6322499 View commit details
    Browse the repository at this point in the history

  41. fix vulture allowlist

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a04b8a3 View commit details
    Browse the repository at this point in the history

  42. fix nesting and type hints

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f1d39bf View commit details
    Browse the repository at this point in the history

  43. strict=False

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    987ea43 View commit details
    Browse the repository at this point in the history

  44. nest import in test file too

    @drammock
    drammock committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    78829b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'new_cluster_stats_api_GSOC24' of https://github.com/Car… 

    …inaFo/mne-python into new_cluster_stats_api_GSOC24
    @CarinaFo
    CarinaFo committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    eb98849 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' into new_cluster_stats_api_GSOC24

    @CarinaFo
    CarinaFo authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ac943e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. clean up pyproject mess

    @CarinaFo
    CarinaFo committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    372bcca View commit details
    Browse the repository at this point in the history

  2. add n_permutations, plotting, added min_cluster_p_value

    @CarinaFo
    CarinaFo committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4da8463 View commit details
    Browse the repository at this point in the history