Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options with vector and optional<vector> targets #18

Merged
merged 9 commits into from
Aug 30, 2023

Conversation

mmahnic
Copy link
Owner

@mmahnic mmahnic commented Aug 30, 2023

Fix problems reported in issue #17.

Fixed

  • The optional targets are now filled correctly.

Changed

  • For options with vector targets the default count changed from minagrs(0) to minargs(1). For
    options with optional<vector> targets the default is still minargs(0).
  • When an option with a vector target has minargs(0) a flagValue is added to the vector only if
    the vector is empty.

@mmahnic mmahnic changed the title Fix options with vector and optional<vector> targets (#17) Fix options with vector and optional<vector> targets Aug 30, 2023
@mmahnic mmahnic merged commit 94f6d59 into master Aug 30, 2023
2 checks passed
@mmahnic mmahnic deleted the support_optional_vector branch August 30, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant