-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GStatSim interface #155
Open
mmaelicke
wants to merge
32
commits into
main
Choose a base branch
from
gstatsim-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GStatSim interface #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull test-fix into interface branch
Very cool! This looks incredibly useful. Let us know if we can help in any way |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 90.74% 90.48% -0.26%
==========================================
Files 23 24 +1
Lines 2475 2639 +164
==========================================
+ Hits 2246 2388 +142
- Misses 229 251 +22
☔ View full report in Codecov by Sentry. |
Merge HEAD into `gstatsim-interface`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GatorGlaciology, this might be interesting for you.
This pull request introduces an preliminary interface to GStatSim. There are 3 main options for interfacing:
prediction_grid
from aVariogram
instanceskrige_sgs
orokrige_sgs
simulation from aVariogram
skrige_sgs
orokrige_sgs
in parallel, from aVariogram
instanceadditionally, the interface defines a
Grid
class, which generates theprediction_grid
but keeps track of the shape needed for the target field, to transform the result. @GatorGlaciology, maybe this class is also helpful for you? I could open a pull request to add it to GStatSim instead of SciKit-GStat, if you are interested.interfaces
prediction grid
You can generate a
prediction_grid
like:simulation parameters
The simulation params can be accessed via the interface
all in one
And finally use the simulation directly
This creates a list of 8 simulated fields. If 8 cores are available, this is as fast as using GStatSim only (or n_jobs=1) as each simulation is run in parallel.
ToDos
@GatorGlaciology, I will add a bit of docs and tests. Meanwhile you are more than welcome to comment on this interface.
I also need to define, which Variogram instances actually can be exported to GStatSim.