Fix #24 Table not updating after tree has changed

[Stromwerk]

This commit fixes the issue of the table not
updating as the tree passed to it changed.
This is done by implementing OnChanges and
rerunning initialization code after the tree
has changed

[mlrv]

Thanks for this @Stromwerk! It's weird that github still seems to be waiting for Travis to complete... I'll see if refreshing a build fixes it.

The change looks great at a first glance, I'll find some time to review it more carefully later on today 👍

[mlrv]

Sorry for the delay in reviewing this @Stromwerk, the change looks good, but there's a lot of duplicated code that could be shared among ngOnInit and ngOnChange. Also, it'd be nice if we could update the tree options as well if the input changes, not just the tree itself.

I feel like it'd be enough to simply take the code that's currently run in ngOnInit and move it to ngOnChange directly, that should take care of everything.

Let me know if this makes sense to you and if you're willing to give it a go.

[Stromwerk]

I completely agree with you that there is unnecessary code duplication, but I seem to recall trying to move everything in ngOnInit into ngOnChange and I got some nasty bugs which I couldn't quite track down. I would need to do some test myself to see how it behaves, but I remember also trying to refactor the duplicated code, but that also introduced some problems of it's own.

I will look into the implementation and test it to see how it could be improved.

[peterjester]

Tested this out locally, and it works really well.

One thing I did notice, and maybe I am doing something wrong, is that when data is updated, it will revert back to the default isExpanded, i.e. if a row is closed when new data is emitted, the entire row will re-open. Is there a way to set the isExpanded to default to closed either in html or programatically?

[mlrv]

Hey @peterjester , thanks for the feedback. I should have some time to properly implement this at some point in the next few days, I'll make sure to include appropriate testing for what you mentioned as well.