Update to new data.table (#999)

DESCRIPTION

@@ -45,7 +45,7 @@ Imports:
     R6 (>= 2.4.1),
     backports,
     checkmate (>= 2.0.0),
-    data.table (>= 1.14.2),
+    data.table (>= 1.15.0),
     evaluate,
     future,
     future.apply (>= 1.5.0),

R/DataBackend.R

@@ -39,7 +39,7 @@
 DataBackend = R6Class("DataBackend", cloneable = FALSE,
   public = list(
     #' @field primary_key (`character(1)`)\cr
-    #' Column name of the primary key column of unique integer row ids.
+    #' Column name of the primary key column of positive and unique integer row ids.
     primary_key = NULL,
 
     #' @field data_formats (`character()`)\cr

R/DataBackendDataTable.R

@@ -67,9 +67,7 @@ DataBackendDataTable = R6Class("DataBackendDataTable", inherit = DataBackend,
       cols = intersect(cols, colnames(private$.data))
 
       if (self$compact_seq) {
-        # https://github.com/Rdatatable/data.table/issues/3109
-        .__i__ = keep_in_bounds(rows, 1L, nrow(private$.data))
-        private$.data[.__i__, cols, with = FALSE]
+        private$.data[rows, cols, with = FALSE, nomatch = NULL]
       } else {
         ijoin(private$.data, rows, cols, self$primary_key)
       }

R/Task.R

@@ -745,7 +745,7 @@ Task = R6Class("Task",
       private$.hash
     },
 
-    #' @field row_ids (`integer()`)\cr
+    #' @field row_ids (positive `integer()`)\cr
     #' Returns the row ids of the [DataBackend] for observations with role "use".
     row_ids = function(rhs) {
       assert_ro_binding(rhs)

R/as_data_backend.R

@@ -67,7 +67,7 @@ as_data_backend.data.frame = function(data, primary_key = NULL, keep_rownames =
   if (is.character(primary_key)) {
     assert_string(primary_key)
     assert_choice(primary_key, colnames(data))
-    assert_integer(data[[primary_key]], any.missing = FALSE, unique = TRUE)
+    assert_integer(data[[primary_key]], any.missing = FALSE, unique = TRUE, lower = 0L)
   } else {
     if (is.null(primary_key)) {
       row_ids = seq_row(data)

inst/testthat/helper_expectations.R

@@ -80,12 +80,12 @@ expect_backend = function(b) {
   checkmate::expect_data_table(x, nrows = 0L, ncols = 0L)
 
   # extra rows are ignored
-  query_rows = c(rn1, if (is.numeric(rn)) -1L else "_not_existing_")
+  query_rows = c(rn1, if (is.numeric(rn)) b$nrow + 1L else "_not_existing_")
   x = b$data(query_rows, cols = cn[1L], data_format = "data.table")
   checkmate::expect_data_table(x, nrows = length(rn1), ncols = 1L)
 
   # zero rows matching
-  query_rows = if (is.numeric(rn)) -1L else "_not_existing_"
+  query_rows = if (is.numeric(rn)) b$nrow + 1L else "_not_existing_"
   x = b$data(rows = query_rows, cols = cn[1L], data_format = "data.table")
   checkmate::expect_data_table(x, nrows = 0L, ncols = 1L)
 

man-roxygen/param_cols.R

@@ -1,2 +1,2 @@
-#' @param cols `character()`\cr
-#'   Column names.
+#' @param cols (`character()`)\cr
+#'   Vector of column names.

man-roxygen/param_rows.R

@@ -1,2 +1,2 @@
-#' @param rows `integer()`\cr
-#'   Row indices.
+#' @param rows (positive `integer()`)\cr
+#'   Vector or row indices.