Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python macos x86 build #178

Merged
merged 14 commits into from
Aug 20, 2024
Merged

Fix Python macos x86 build #178

merged 14 commits into from
Aug 20, 2024

Conversation

mlondschien
Copy link
Owner

No description provided.

@mlondschien
Copy link
Owner Author

@xhochy
in ac6c776, the macos universal2 build for python 3.8 failed with

         error[E0463]: can't find crate for `core`
          |
          = note: the `x86_64-apple-darwin` target may not be installed
          = help: consider downloading the target with `rustup target add x86_64-apple-darwin`

I thought universal2 was aarch?

I added a line to install the x86_64-apple-darwin target for the universal2 builds. Now the Python 3.13 build test stage fails with

    × Preparing metadata (pyproject.toml) did not run successfully.
    │ exit code: 1
    ╰─> [2 lines of output]
        
        meson-python: error: Multi-architecture builds are not supported but $ARCHFLAGS='-arch arm64 -arch x86_64'
        [end of output]

Before I simply don't build for Python 3.13: Is there something I am misunderstanding here?

@xhochy
Copy link
Contributor

xhochy commented Aug 20, 2024

universal2 is x86 and aarch64 at the same time. I wouldn't build these wheels as they are quite heavy and barely used if you provide wheels for the architectures separately already.

@mlondschien mlondschien force-pushed the fix-build branch 2 times, most recently from 47ef0c7 to e9859e8 Compare August 20, 2024 14:15
@mlondschien
Copy link
Owner Author

Thanks @xhochy !

@mlondschien mlondschien enabled auto-merge (squash) August 20, 2024 14:15
@mlondschien mlondschien merged commit bdaf6f0 into main Aug 20, 2024
34 of 36 checks passed
@mlondschien mlondschien deleted the fix-build branch August 20, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants