Add safeglobals to allow metaclip models to load with weights_only=True #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue, add bigG metaclip while working with them
bryant1410
reviewed
Oct 21, 2024
| import numpy as np | ||
| # add safe globals, known to be needed for metaclip weights | ||
| torch.serialization.add_safe_globals([ | ||
| _codecs.encode, # now in pytorch main but some pytorch versions w/ weights_only flag don't have it |
There was a problem hiding this comment.
What if you specify that's not necessary from PyTorch 2.5.0 (I checked this)?
There was a problem hiding this comment.
For accountability, this is how I checked it's in that release (tag): I opened pytorch/pytorch@1e9bedf, and saw that it contains the tag v2.5.0 (meaning that this commit is included in the tag, thus the release).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.