Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern pytorch (1.10+) always performs LN in fp32:
So it's no longer necessary to use
LayerNormFp32
to explicitly cast to fp32. However, the built-intorch.nn.LayerNorm
always returns in fp32 when run under theautocast()
context, so we still need theLayerNorm
subclass to cast back. See also pytorch/pytorch#66707 (comment).