Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.23.0 #679

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Release 2.23.0 #679

merged 2 commits into from
Oct 24, 2023

Conversation

gabrielilharco
Copy link
Collaborator

Closes #678

@rwightman
Copy link
Collaborator

@gabrielilharco FYI I don't think merging release via PR triggers a release @rom1504 ... at least it didn't last time. Also, might want to wait until the nltk thing is fixed up as this will push it into an active release...

@gabrielilharco
Copy link
Collaborator Author

@rwightman sgtm, we can wait for the nice SigLIP+CLIPA PR and do a big one. As for the trigger, maybe it depends on how the PR is merged? Seems to work for Squash and merge at least (e.g. #511)

@rom1504
Copy link
Collaborator

rom1504 commented Oct 18, 2023

It does trigger a release as long as the commit is named "Release X.Y.Z"

@rom1504
Copy link
Collaborator

rom1504 commented Oct 18, 2023

What about merging the ntlk thing before the big clippa/siglip is merged? It would not hurt to have some people use the current state of the repo, just in case anything is wrong

@rwightman
Copy link
Collaborator

@rom1504 it'd be entirely separate fix that I'd have to ignore on the SigLIP PR on merge as I refactored the tokenizers to get rid of the singleton. Someone else is welcome to do that.

@rom1504
Copy link
Collaborator

rom1504 commented Oct 18, 2023

Ok if it's not trivial then I guess let's wait

@gabrielilharco gabrielilharco merged commit f08f25f into mlfoundations:main Oct 24, 2023
5 checks passed
Interpause pushed a commit to Interpause/open_clip that referenced this pull request May 23, 2024
* Release 2.23.0

* Update HISTORY.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetaCLIP models release in stable version
3 participants