Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Profile Page #834

Merged
merged 18 commits into from
Jan 2, 2024
Merged

New Profile Page #834

merged 18 commits into from
Jan 2, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Dec 29, 2023

Redesigned the profile page.

@Sjmarf Sjmarf requested a review from a team as a code owner December 29, 2023 17:22
@Sjmarf Sjmarf requested review from WestonHanners and ShadowJonathan and removed request for a team December 29, 2023 17:22
@Sjmarf Sjmarf changed the title New Profile page New Profile Page Dec 29, 2023
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments but looks good overall!

Mlem/Enums/FeedType.swift Outdated Show resolved Hide resolved
Mlem/Enums/FeedType.swift Outdated Show resolved Hide resolved
Mlem/Views/Tabs/Profile/UserView+Logic.swift Outdated Show resolved Hide resolved
Mlem/Views/Tabs/Profile/UserView.swift Outdated Show resolved Hide resolved
@Sjmarf Sjmarf mentioned this pull request Jan 1, 2024
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks great

@Sjmarf Sjmarf enabled auto-merge (squash) January 2, 2024 22:21
@Sjmarf Sjmarf disabled auto-merge January 2, 2024 22:24
@Sjmarf Sjmarf enabled auto-merge (squash) January 2, 2024 22:25
@Sjmarf Sjmarf merged commit c2f5a21 into dev Jan 2, 2024
4 checks passed
@Sjmarf Sjmarf deleted the sjmarf/new-profile branch January 2, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants