Search Reselection #833
Merged
Search Reselection #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners and
ShadowJonathan
and removed request for
a team
EricBAndrews
force-pushed
the
eric/search-reselection-2
branch
from
3753677
to
2ccfe70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- closes Feature request: Tapping search tab again to focus search bar #246
Pull Request Information
This PR enables re-selecting the search tab to focus the search bar, provided that the feed is already scrolled to the top. I needed to do some slightly unsightly things to the SwiftUIX search bar to make the reselection work, as
let uiView = uiView as? _UISearchBarnever seems to execute and so the stock.focuseddoesn't work--the hack I've written doesn't have binding support, so *de-*selecting search requires some manual work, but since navigating off of the search tab usually requires dismissing the keyboard and therefore unfocusing search I don't think that's a huge problem.Screen.Recording.2023-12-28.at.5.51.17.PM.mov
Screen.Recording.2023-12-28.at.5.51.42.PM.mov