Don't wipe all accounts if keychain token cannot be found #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjmarf
requested review from
WestonHanners and
JakeShirley
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a token wasn't found in the keychain Mlem would reset the JSON account list file. Instead of resetting the JSON file, I've made it fallback to setting an arbitrary string as the token. This will cause Mlem to pick up on the token being invalid when it tries to perform an authenticated request, and show the re-auth sheet.
In normal circumstances, a token should always be present in the keychain. However, in #1416 an account's token is consistently missing from the keychain. I haven't been able to reproduce this exact issue myself yet.