Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Swipe anywhere to Navigate" setting #1408

Merged
merged 5 commits into from
Oct 30, 2024
Merged

"Swipe anywhere to Navigate" setting #1408

merged 5 commits into from
Oct 30, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Oct 26, 2024

If General -> Swipe anywhere to Navigate is enabled, you can swipe anywhere on the screen to go back rather than only at the edges.

Also fixed a bug in which feed post corners weren't clipped if Swipe Actions were turned off.

Closes #130

@Sjmarf Sjmarf requested a review from a team as a code owner October 26, 2024 12:31
@Sjmarf Sjmarf requested review from JakeShirley and EricBAndrews and removed request for a team October 26, 2024 12:31
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, works well!

If swipe actions are on, it may not be immediately clear that they need to be disabled for this setting to be activated--we should at least offer an explanatory footer, and possibly flip the swipe actions toggle off when swipe navigation is enabled (the same as is done when going the other way)

@Sjmarf
Copy link
Contributor Author

Sjmarf commented Oct 27, 2024

Hm, I can't think of a good footer that's not too verbose. Any ideas? Alternatively we could swap out the two toggles for a single picker or something? That might not be as clear though

@EricBAndrews
Copy link
Member

EricBAndrews commented Oct 28, 2024

The best I can come up with for footer is "Only one of these can be active at a time"--I agree that a picker isn't as clear. We might not need a footer if they just automatically swap--that behavior should be clear enough, though you can never be too sure

@Sjmarf
Copy link
Contributor Author

Sjmarf commented Oct 29, 2024

I've made both toggles enabled at all times, and turning one on turns the other off. Maybe that's clear enough without needing a footer?

@EricBAndrews
Copy link
Member

Works for me 👍

@Sjmarf Sjmarf merged commit cf9cc2d into dev Oct 30, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/swipe-anywhere branch October 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swipe to navigate
2 participants