Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show save icon in compact post #1404

Merged
merged 2 commits into from
Oct 24, 2024
Merged

show save icon in compact post #1404

merged 2 commits into from
Oct 24, 2024

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • If this PR alters the UI, I have attached pictures/videos
  • This PR addresses one or more open issues that were assigned to me:
    - closes Saved status not shown in compact post #1403

Pull Request Information

Adds saved status to compact post. We don't want to show the empty icon if not saved in compact mode, but we do want it in larger modes if the user adds it to the info stack, so I've also updated the InfoStackView's post convenience init to accept nil array values.

@EricBAndrews EricBAndrews requested a review from a team as a code owner October 22, 2024 21:35
@EricBAndrews EricBAndrews requested review from JakeShirley, mormaer and Sjmarf and removed request for a team October 22, 2024 21:35
Copy link
Contributor

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@EricBAndrews EricBAndrews merged commit a1e92de into dev Oct 24, 2024
2 checks passed
@EricBAndrews EricBAndrews deleted the eric/save-improvements branch October 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved status not shown in compact post
2 participants