Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Posts #1376

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Search Posts #1376

merged 11 commits into from
Oct 10, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Oct 5, 2024 •
edited
Loading

Relies on this MlemMiddleware PR. Also redesigned the ...ListRow views to be more bubbly

@Sjmarf Sjmarf requested a review from a team as a code owner October 5, 2024 15:09
@Sjmarf Sjmarf requested review from WestonHanners and EricBAndrews and removed request for a team October 5, 2024 15:09
@Sjmarf Sjmarf marked this pull request as draft October 6, 2024 14:38
@Sjmarf Sjmarf marked this pull request as ready for review October 6, 2024 20:01
EricBAndrews
EricBAndrews approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

Mlem.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@Sjmarf Sjmarf enabled auto-merge (squash) October 10, 2024 13:23
@Sjmarf Sjmarf merged commit fe0bf8c into dev Oct 10, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/search-posts branch October 10, 2024 13:26
@Sjmarf Sjmarf mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sjmarf @EricBAndrews