Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up Prompts #1356

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Sign Up Prompts #1356

merged 4 commits into from
Sep 26, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Sep 23, 2024

When the user has no permanent accounts, they'll see the following prompts:

The "Welcome to Lemmy!" prompt can be dismissed by pressing the X button, and brought back by going to Settings -> Advanced -> Developer.

If the user is using a saved guest account rather than a temporary one, they'll see this prompt in the Inbox tab:

(I also moved some of the InboxView code into another file; SwiftLint was complaining about it)

@Sjmarf Sjmarf requested a review from a team as a code owner September 23, 2024 09:38
@Sjmarf Sjmarf requested review from WestonHanners and EricBAndrews and removed request for a team September 23, 2024 09:38
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Sjmarf Sjmarf merged commit 2a0809d into dev Sep 26, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/sign-up-prompts branch September 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants