Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iPad sidebar #1338

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix iPad sidebar #1338

merged 4 commits into from
Sep 20, 2024

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Sep 18, 2024

Sidebar navigation wasn't working at all

@Sjmarf Sjmarf requested a review from a team as a code owner September 18, 2024 21:38
@Sjmarf Sjmarf requested review from WestonHanners and JakeShirley and removed request for a team September 18, 2024 21:38
EricBAndrews
EricBAndrews requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works perfectly. The list items probably want rounded corners + dividers:
Screenshot 2024-09-19 at 6 08 18 PM

Mlem/App/Views/Root/Tabs/Feeds/SubscriptionListItemView.swift Outdated Show resolved Hide resolved
@Sjmarf
Copy link
Contributor Author

Sjmarf commented Sep 19, 2024

Nice! Works perfectly. The list items probably want rounded corners + dividers:

This was there before this PR, I'm leaving as OOS and fixing in #1326

EricBAndrews
EricBAndrews approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Sjmarf Sjmarf enabled auto-merge (squash) September 20, 2024 17:42
@Sjmarf Sjmarf merged commit 63abf6b into dev Sep 20, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/fix-ipad-navigation branch September 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@WestonHanners WestonHanners Awaiting requested review from WestonHanners WestonHanners is a code owner automatically assigned from mlemgroup/mlem-dev-team

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sjmarf @EricBAndrews