Using more than one account on ipad removes all accounts

[nocturne213]

Describe the bug
What did you do to trigger the bug?
Added a second account on ipad

Expected Behavior
What did you expect to happen?
I would be able to swap between accounts

Actual Behavior
What actually happened?
The next time i opened mlem both of my accounts were removed and i had to log in again.

To Reproduce
What steps do I need to take to trigger the bug?
Log into an account (i was using sipuli.xyz) then add a second account (i used mtgzone.com) then when opening a link from within a post mlem fully closed, when i reopened mlem neither account was available and mlem was showing a guest Lemmy.world account.

Mlem Information:
Version + Build number
If this started happening recently, write which version introduced the bug
I remember this happening when version 2.0 first came out, i almost exclusively use my sopuli account so I never tried again after the first time until tonight. I am using ver 2.0 (114) on ipad pro iOS 18.1.

Additional Context
Any other relevant information

[nocturne213]

It appear to not be limited to iPad, but possibly certain instances. I was logged into mtgzone on both my iPhone and iPad and was logged out of all accounts on both devices. I previously had 2 or 3 different accounts logged in on the iPhone. The only difference was adding the mtgzone account.

[Sjmarf]

Hmm, that's interesting. I've not seen this issue so it being related to mtg.zone is plausible. Accounts being wiped is a result of a decoding error when opening the app, normally... we should really make Mlem log those errors somewhere permanent to make debugging easier.

When the accounts gets wiped, an "error" popup might be shown - if it happens again and you tap on the "error" popup before it goes away, it'll show the exact error. On the off chance it happens again, having that error information would be useful for us.

[nocturne213]

The operation couldn’t be completed. (Mlem.UserAccount.DecodingError error 1.)

after more testing it happens on iPhone as well as iPad. It happens when I am logged in only on mtgzone.com as well as logged into other instances as well. It was more noticeable on iPad because pretty much every time you minimize Mlem on iPad it crashes. But if you log in on iPhone, then swipe away Mlem and reopen it it gives the above error and logs out all accounts.

[Sjmarf]

Thanks, that's narrowed it down a lot.

The issue is caused by Mlem not being able to retrieve the account authorization token from the keychain. I can't reproduce this issue myself, which makes the exact cause tricky to pinpoint and fix. For now, I've submitted a PR that makes Mlem ask for the account password if it can't retrieve the token, rather than wiping the accounts list. I'll keep looking for a proper fix.

[nocturne213]

I do not know if you're change made it into the weekly, but the issue persisted today after updating.

[Sjmarf]

That change hasn't merged yet, no. It'll probably be in the next weekly