Skip to content

Commit

Permalink
Phrasing
Browse files Browse the repository at this point in the history
  • Loading branch information
Sjmarf committed Oct 29, 2024
1 parent 57302ad commit b99f4df
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions Mlem/App/Views/Shared/ExpandedPost/CommentTreeTracker.swift
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,16 @@ class CommentTreeTracker: Hashable {
// From 0.19.0 onwards, a comment's parent is guaranteed to precede it in the array.
//
// In 0.18.x versions, this isn't always the case - sometimes the parent can come after
// the child. To solve this, we sort the comments by depth before processing them on
// 0.18.x instances.
// the child. As the tree-building logic relies on correct comment order, we need to sort
// the comments by depth before processing them.
//
// In super large comment threads where some comments are hidden under "More replies",
// comments may be included that don't have a parent *anywhere* in the list! There's
// nothing we can do in that circumstance, so those comments are ignored entirely. I'm
// not sure under what circumstances this happen - the absent parent comments are neither
// removed nor deleted. Going to the parent comment on lemmy-ui loads the comment just
// fine, but neither the "Show context" nor "Show replies" buttons work. This could be a
// Lemmy version issue, or maybe Beehaw's database is broken somehow.
// Comment example: https://beehaw.org/comment/4033679
// not sure under what circumstances this happens. Going to the parent comment on lemmy-ui
// loads the comment just fine, but neither the "Show context" nor "Show replies" buttons
// work. This issue could be related to Lemmy 0.18, or maybe Beehaw's database is broken
// somehow. Comment example: https://beehaw.org/comment/4033679

var sortedComments: [Comment2]
if let version = try? await newComments.first?.api.version, version < .v19_0 {
Expand Down

0 comments on commit b99f4df

Please sign in to comment.