improved docs #167
Open
improved docs #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomanimc
reviewed
Feb 16, 2021
There was a problem hiding this comment.
Hi @sakshiii-bit! Thank you for taking a look at our LICENSE to suggest some improvements. I've left a few comments with questions for you.
Congrats on opening your first PR!
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2019 ml5 | |||
| Copyright (c) 2020 ml5 | |||
There was a problem hiding this comment.
Based on my understanding, it looks like we don't need to update the license date as this year references the start date of the copyright. More on this here: https://softwareengineering.stackexchange.com/questions/130478/what-copyright-date-for-an-update-to-an-open-source-project-from-last-year.
Would you be able to share more information about this? Is there a best practice in maintaining these dates that iI may be overlooking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?