Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table rename #122

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Table rename #122

merged 3 commits into from
Oct 24, 2023

Conversation

mkuthan
Copy link
Owner

@mkuthan mkuthan commented Oct 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #122 (8631ef7) into main (8a36bf2) will decrease coverage by 0.56%.
Report is 13 commits behind head on main.
The diff coverage is 70.17%.

❗ Current head 8631ef7 differs from pull request most recent head 55854ab. Consider uploading reports for the commit 55854ab to get more accurate results

@@             Coverage Diff              @@
##               main     #122      +/-   ##
============================================
- Coverage     60.37%   59.81%   -0.56%     
  Complexity      116      116              
============================================
  Files            84       84              
  Lines          1219     1212       -7     
  Branches        154      157       +3     
============================================
- Hits            736      725      -11     
- Misses          394      397       +3     
- Partials         89       90       +1     
Files Coverage Δ
...ocessing/toll/application/batch/TollBatchJob.scala 83.33% <100.00%> (ø)
...ng/toll/application/batch/TollBatchJobConfig.scala 95.83% <100.00%> (ø)
...essing/toll/application/batch/TollBatchJobIo.scala 100.00% <100.00%> (ø)
...application/streaming/TollStreamingJobConfig.scala 97.05% <100.00%> (+0.18%) ⬆️
...oll/application/streaming/TollStreamingJobIo.scala 100.00% <100.00%> (ø)
...mprocessing/toll/domain/booth/TollBoothEntry.scala 83.33% <50.00%> (-0.39%) ⬇️
...amprocessing/toll/domain/booth/TollBoothExit.scala 78.12% <50.00%> (-0.67%) ⬇️
...mprocessing/toll/domain/booth/TollBoothStats.scala 78.26% <50.00%> (-0.91%) ⬇️
...toll/domain/registration/VehicleRegistration.scala 73.17% <50.00%> (-0.64%) ⬇️
...essing/toll/domain/booth/TollBoothDiagnostic.scala 61.90% <25.00%> (+1.90%) ⬆️
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Terraform plan in toll-infrastructure

Plan: 1 to add, 15 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # google_bigquery_table.io-diagnostic-table will be updated in-place
  ~ resource "google_bigquery_table" "io-diagnostic-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/io-diagnostic"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.toll-booth-entry-stats-daily-table will be updated in-place
  ~ resource "google_bigquery_table" "toll-booth-entry-stats-daily-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/toll-booth-entry-stats-daily"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.toll-booth-entry-stats-hourly-table will be updated in-place
  ~ resource "google_bigquery_table" "toll-booth-entry-stats-hourly-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/toll-booth-entry-stats-hourly"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.toll-booth-entry-stats-table will be updated in-place
  ~ resource "google_bigquery_table" "toll-booth-entry-stats-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/toll-booth-entry-stats"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.toll-booth-entry-table will be updated in-place
  ~ resource "google_bigquery_table" "toll-booth-entry-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/toll-booth-entry"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.toll-booth-exit-table will be updated in-place
  ~ resource "google_bigquery_table" "toll-booth-exit-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/toll-booth-exit"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.total-vehicle-times-diagnostic-table will be updated in-place
  ~ resource "google_bigquery_table" "total-vehicle-times-diagnostic-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/total-vehicle-times-diagnostic"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.total-vehicle-times-one-hour-gap-diagnostic-table will be updated in-place
  ~ resource "google_bigquery_table" "total-vehicle-times-one-hour-gap-diagnostic-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/total-vehicle-times-one-hour-gap-diagnostic"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.total-vehicle-times-one-hour-gap-table will be updated in-place
  ~ resource "google_bigquery_table" "total-vehicle-times-one-hour-gap-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/total-vehicle-times-one-hour-gap"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.total-vehicle-times-table will be updated in-place
  ~ resource "google_bigquery_table" "total-vehicle-times-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/total-vehicle-times"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.vehicle-registration-table will be updated in-place
  ~ resource "google_bigquery_table" "vehicle-registration-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/vehicle-registration"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (2 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.vehicles-with-expired-registration-daily-diagnostic-table will be updated in-place
  ~ resource "google_bigquery_table" "vehicles-with-expired-registration-daily-diagnostic-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/vehicles-with-expired-registration-daily-diagnostic"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.vehicles-with-expired-registration-daily-table will be updated in-place
  ~ resource "google_bigquery_table" "vehicles-with-expired-registration-daily-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/vehicles-with-expired-registration-daily"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.vehicles-with-expired-registration-diagnostic-table will be updated in-place
  ~ resource "google_bigquery_table" "vehicles-with-expired-registration-diagnostic-table" {
        id                       = "projects/playground-272019/datasets/toll_application/tables/vehicles-with-expired-registration-diagnostic"
      + require_partition_filter = true
        # (18 unchanged attributes hidden)

      ~ time_partitioning {
          - require_partition_filter = true -> null
            # (3 unchanged attributes hidden)
        }
    }

  # google_bigquery_table.vehicles-with-expired-registration-table will be created
  + resource "google_bigquery_table" "vehicles-with-expired-registration-table" {
      + creation_time            = (known after apply)
      + dataset_id               = "****************"
      + deletion_protection      = false
      + effective_labels         = (known after apply)
      + etag                     = (known after apply)
      + expiration_time          = (known after apply)
      + id                       = (known after apply)
      + last_modified_time       = (known after apply)
      + location                 = (known after apply)
      + num_bytes                = (known after apply)
      + num_long_term_bytes      = (known after apply)
      + num_rows                 = (known after apply)
      + project                  = "playground-272019"
      + require_partition_filter = true
      + schema                   = jsonencode(
            [
              + {
                  + name = "created_at"
                  + type = "TIMESTAMP"
                },
              + {
                  + name = "vehicle_registration_id"
                  + type = "STRING"
                },
              + {
                  + name = "toll_booth_id"
                  + type = "STRING"
                },
              + {
                  + name = "entry_time"
                  + type = "TIMESTAMP"
                },
              + {
                  + name = "license_plate"
                  + type = "STRING"
                },
            ]
        )
      + self_link                = (known after apply)
      + table_id                 = "**********************************"
      + terraform_labels         = (known after apply)
      + type                     = (known after apply)

      + time_partitioning {
          + expiration_ms = (known after apply)
          + field         = "created_at"
          + type          = "DAY"
        }
    }

  # google_storage_bucket.toll-application-bucket will be updated in-place
  ~ resource "google_storage_bucket" "toll-application-bucket" {
      ~ force_destroy               = false -> true
        id                          = "playground-272019-toll-application"
        name                        = "playground-272019-toll-application"
        # (12 unchanged attributes hidden)

      + lifecycle_rule {
          + action {
              + type = "Delete"
            }
          + condition {
              + age                   = 30
              + matches_prefix        = []
              + matches_storage_class = []
              + matches_suffix        = []
              + with_state            = (known after apply)
            }
        }
    }

Plan: 1 to add, 15 to change, 0 to destroy.

✅ Plan applied in Terraform apply #12

@mkuthan mkuthan enabled auto-merge (squash) October 24, 2023 06:43
@mkuthan mkuthan merged commit 040d876 into main Oct 24, 2023
8 checks passed
@mkuthan mkuthan deleted the table-rename branch October 24, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant