cleaner error when unloading fails

mkoohafkan · Aug 5, 2019 · af240bf · af240bf
1 parent 008ade6
commit af240bf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/R/connect.r b/R/connect.r
@@ -192,10 +192,12 @@ hql_unload = function() {
 	if (hql_is_loaded()) {
 		dllpath = normalizePath(file.path(hql.paths$install,
 			hql.paths$dll), mustWork = TRUE)
-		lapply(dllpath, dyn.unload)
-		if (hql_is_loaded()) {
-			stop("HDFql DLLs could not be unloaded.")
-		}
+    for (dll in dllpath) {
+      dyn.unload(dll)
+      if (dll %in% sapply(getLoadedDLLs(), function(x) normalizePath(x[["path"]], mustWork = FALSE))) {
+        stop("Error unloading HDFql shared library object ", dll)
+      }
+    }
 		rm(list = "wrapper", envir = hql)
 	}
   invisible(NULL)

diff --git a/R/zzz.r b/R/zzz.r
@@ -15,9 +15,15 @@
 }
 
 .onUnload = function(libpath) {
-  hql_unload()
+  tryCatch(hql_unload(),
+    error = function(e) {
+      warning(packageName(), " could not be unloaded cleanly\n", e$message)
+    })
 }
 
 .onDetach = function(libpath) {
-  hql_unload()
+  tryCatch(hql_unload(),
+    error = function(e) {
+      warning(packageName(), " could not be unloaded cleanly\n", e$message)
+    })
 }