-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update File Name task #861
base: main
Are you sure you want to change the base?
Conversation
@Sora201710 this appears to work as intended but I think "update_files" might be confusing to others, since this new task doesn't update files, it just updates files' names. Can you change all uses of "update_files" to "update_filenames", including in comments and in tests? |
@mjordan I've changed it. |
@Sora201710 my apologies for taking so long. What does the "id" column in the input CSV refer to? Your testing instructions say "For the csv file, you only need the file_id (the file you are trying to update) and filename (the new, updated file name)" and I don't see it referenced in the |
I'll test and merge and we can figure out the "id" question later. |
@@ -0,0 +1,7 @@ | |||
task: update_filenames | |||
host: https://islandora.traefik.me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test config files now need to use host: https://islandora.dev
@@ -0,0 +1,7 @@ | |||
task: create | |||
host: https://islandora.traefik.me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test config files now need to use host: https://islandora.dev
Link to Github issue or other discussion
What does this PR do?
What changes were made?
How to test / verify this PR?
Interested Parties
Checklist
setup.py
?