Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Accessibility #2738

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Improve Accessibility #2738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd4ec4
Improve Accessibility
garrettjohnson Sep 1, 2023
55c25ac
Update SocialElement.js
garrettjohnson Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/components_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ A MJML document starts with a `<mjml>` tag, it can contain only `mj-head` and `m
attribute | unit | description | default value
----------|------|-------------|---------------
owa | string | if set to "desktop", switch force desktop version for older (self-hosted) version of Outlook.com that doesn't support media queries (cf. [this issue](https://github.com/mjmlio/mjml/issues/2241)) | none
lang | string | used as `<html lang="">` attribute | none
dir | string | used as `<html dir="">` attribute | none
lang | string | used as `<html lang="">` attribute | und
dir | string | used as `<html dir="">` attribute | auto


## mj-head
Expand Down
2 changes: 1 addition & 1 deletion packages/mjml-carousel/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ This component enables you to add and style the images in the carousel.

attribute | unit | description | default value
----------|------|-------------|---------------
alt | string | image description | n/a
alt | string | image description | ''
css-class | string | class name, added to the root HTML element created | n/a
href | url | link to redirect to on click | n/a
rel | string | specify the rel attribute | n/a
Expand Down
1 change: 1 addition & 0 deletions packages/mjml-carousel/src/CarouselImage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export default class MjCarouselImage extends BodyComponent {
}

static defaultAttributes = {
alt: '',
target: '_blank',
}

Expand Down
5 changes: 1 addition & 4 deletions packages/mjml-core/src/helpers/skeleton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,8 @@ export default function skeleton(options) {
dir,
} = options

const langAttribute = lang ? `lang="${lang}" ` : ''
const dirAttribute = dir ? `dir="${dir}" ` : ''

return `${beforeDoctype ? `${beforeDoctype}\n` : ''}<!doctype html>
<html ${langAttribute}${dirAttribute}xmlns="http://www.w3.org/1999/xhtml" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office">
<html lang="${lang}" dir="${dir}" xmlns="http://www.w3.org/1999/xhtml" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office">
<head>
<title>${title}</title>
<!--[if !mso]><!-->
Expand Down
4 changes: 2 additions & 2 deletions packages/mjml-core/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ export default function mjml2html(mjml, options = {}) {
style: [],
title: '',
forceOWADesktop: get(mjml, 'attributes.owa', 'mobile') === 'desktop',
lang: get(mjml, 'attributes.lang'),
dir: get(mjml, 'attributes.dir'),
lang: get(mjml, 'attributes.lang') || 'und',
dir: get(mjml, 'attributes.dir') || 'auto',
}

const validatorOptions = {
Expand Down
2 changes: 1 addition & 1 deletion packages/mjml-image/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Note that if no width is provided, the image will use the parent column width.
attribute | unit | description | default value
------------------------------|---------------|--------------------------------|-----------------------------
align | position | image alignment | center
alt | string | image description | n/a
alt | string | image description | ''
border | string | css border definition | none
border-top | string | css border definition | none
border-bottom | string | css border definition | none
Expand Down
1 change: 1 addition & 0 deletions packages/mjml-image/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export default class MjImage extends BodyComponent {
}

static defaultAttributes = {
alt: '',
align: 'center',
border: '0',
height: 'auto',
Expand Down
2 changes: 1 addition & 1 deletion packages/mjml-social/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ Note that default icons are transparent, which allows `background-color` to actu
attribute | unit | description | default value
----------------------------|-------------|-------------------------------|---------------------------
align | string | left/right/center | center
alt | string | image alt attribute | none
alt | string | image alt attribute | ''
background-color | color | icon color | Each social `name` has its own default
border-radius | px | border radius | 3px
color | color | text color | #333333
Expand Down
1 change: 1 addition & 0 deletions packages/mjml-social/src/SocialElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export default class MjSocialElement extends BodyComponent {
}

static defaultAttributes = {
alt: '',
align: 'left',
color: '#000',
'border-radius': '3px',
Expand Down
Loading