manager: Resort extension list only with sort-enabled-first #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscfdezdz
force-pushed
the
fix-focus-loss
branch
from
fa89369 to
1d460bb
Compare
oscfdezdz
force-pushed
the
fix-focus-loss
branch
from
1d460bb to
e7580fa
Compare
oscfdezdz
force-pushed
the
fix-focus-loss
branch
from
e7580fa to
6c9330b
Compare
|
Every time I come back to this issue, the more it seems to me that the only solution is to handle the list manually instead of with |
oscfdezdz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for RFC. This is the most trivial way to solve it but as you can see in the code, it doesn't work when the sort enabled first option is enabled.
I haven't thought yet how we could cover both cases, but we would have to save the last focus possibly in
ExmInstalledPageor something similar.Helps #220