-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Unified Extensions Subsystem #517
base: master
Are you sure you want to change the base?
Conversation
aa6334e
to
58d08ee
Compare
Rebased on master (with some breakages). Time to tackle that to do list... 🔨 |
Rebased again - now using property bindings for populating the details view. It's still pretty broken, but we can bind the Further steps could be finding a way to load the screenshot, icon, comments, etc via property binding and blueprint. It would be nice to e.g. declare an ExmImageResolver in the blueprint code and set the URL there and have everything magically work in the background. |
I guess changing the type of |
Co-authored-by: Óscar Fernández Díaz <[email protected]>
Unify the local and web representations of Extensions
This allows us to use online data and fallback to local data when it is not available.
Practically speaking, it unblocks:
Currently, this removes the dropdown in the local extensions view as requested in the Circle review. However, I won't merge this until we make it instant otherwise it's a huge regression (and annoyance). We can do this by:
TODO for this PR:
What this looks like: