Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FramePos type and use it for beatgrid creation #4043
Add FramePos type and use it for beatgrid creation #4043
Changes from 27 commits
18382f5
6df3614
34d1f9d
92161c5
4a7bdc5
e3124ff
e98439f
eb550fa
b048478
9ae96f2
3d9df08
7a05af6
db6b5f6
aa17102
f79e907
4db7cb2
b82ba59
e7e39e4
0191a50
af40d4f
cd8b88c
69c3717
f808edb
fb2be0b
e4f9b22
9d2811c
35a5ccd
e671a6c
ad42583
c26b018
70416aa
a555ae4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the function mame it is not clear if it is foor or ceil or round.
Let's either remove this function or rename it.
Do we need the other candidates as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Floor is not int cast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I mentioned the naming is not ideal I had something like
toLowerFrameBoundary()
in mind.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uklotzde Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that for the future we need a more sophisticated solution:
epsilon
) to a beat then usestd::round
The value of
epsilon
may also vary.