-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(actions): Update translations automatically #13773
base: main
Are you sure you want to change the base?
Conversation
with: | ||
branch: pull-translations/${{ matrix.branch }} | ||
commit-message: |- | ||
Pull Transifex translations for ${{ matrix.branch }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Transifex translations for ${{ matrix.branch }} | |
chore(translations): Pull ${{ matrix.branch }} branch from Transifex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit-y, but commitlint enforce the subject case to start with lower case by default. I know we don't use this linter and that subject-case
is highly controversial,s o happy to keep it as is, but I think it's common to use lower cased subject
Pull Transifex translations for ${{ matrix.branch }} | |
chore(translations): pull ${{ matrix.branch }} branch from Transifex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you
super nit-y, but commitlint enforce the subject case to start with lower case by default.
Are you sure about that? To me it looks like Start Case, Sentence case, lower case and UPPER CASE are allowed by default: https://commitlint.js.org/reference/rules.html#subject-case
The actual Conventional Commit spec does not enforce any specific case for the subject: https://www.conventionalcommits.org/en/v1.0.0/#are-the-types-in-the-commit-title-uppercase-or-lowercase
Personally I'm in favor of Sentence case
for readability (and also because all lowercase looks kind of lazy to me xD).
|
||
on: | ||
schedule: | ||
- cron: "0 0 1 * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will run on the first day of every month at 12 a.m.
Is is too often? Or too rare? Suggestions welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would almost vote too rare - how expansive is a run? (build time, bandwidth, ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For main the job takes 51 secs on my fork, see https://github.com/Holzhaus/mixxx/actions/runs/11354842443/job/31582931642
Do I see it correct, that compilation of all .ts files together need only 2 seconds CI time? If yes I would suggest to move this step in the normal build and get rid of the binary files stored in the git repository. |
For a PR review, neither the .qm files(binary) nor the .ts files (huge because of line number changes) are suitable. |
"Two stupid people, one thought" as we say in Germany 😛 |
I don't think that we can/will ever use this PR for review translations. The review needs to be done at Transifex by native speakers. Let's just rely on Transifex here and merge this blindly. |
@daschuer Agreed, I did not open this PR to ensure manual reviews of translation PRs, just to make pulling translations easier and less work, and maybe we can do it more often. |
I think it would be great to still have PR, even if we don't review them with as much involvement as we would do for code. We had a case a few month ago where One question on PR - does it update the previously open PR or does it create a new one? I know renovate does that with deps update so I'm wondering if this is an option to reduce spam. |
It does update the original PR. See https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-behaviour. |
The diff is huge. However, we could do an automated scan using something like https://github.com/IEvangelist/profanity-filter. I'm also currently looking into allowlisting certain PRs to be auto-merged by CI once all checks passed. |
Yeah I realised that it was regenerating a lot of stuff after commenting. |
This automatically fetches translations from transifex, compiles them and then opens a PR to merge them. See Holzhaus#25 for an example PR that was opened by the bot.
TODO:
TRANSIFEX_TOKEN
secret to the repo secrets.