Fixing list mistake

mixcloud · Apr 3, 2017 · 603baac · 603baac
1 parent e3c4e66
commit 603baac
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 8 deletions.
diff --git a/src/__tests__/testGenerate.js b/src/__tests__/testGenerate.js
@@ -91,8 +91,8 @@ export type Single = {|
     objectListField: Array<{|
         stringField: string
     |}>,
-    nullableEmptyObjectListField: null | {||},
-    emptyObjectListField: {||}
+    nullableEmptyObjectListField: null | Array<{||}>,
+    emptyObjectListField: Array<{||}>
 |};
 
 export type Duplicate1 = {|

diff --git a/src/__tests__/testParse.js b/src/__tests__/testParse.js
@@ -79,6 +79,24 @@ Relay.QL\`query {
         });
     });
 
+    it('should handle empty lists of items', () => {
+        expect(parse(`
+            Relay.QL\`
+                fragment on User {
+                    todos {
+                        \${SomeComponent.getFragment('todos')}
+                    }
+                }
+            \`
+        `, schema)).toEqual({
+            UserFragmentType: [
+                {
+                    todos: {type: 'list', ofType: {type: 'object', object: {}, nonNull: true}, nonNull: true}
+                }
+            ]
+        });
+    });
+
     it('should handle variables included as fragments', () => {
         expect(parse(`
             Relay.QL\`

diff --git a/src/generate.js b/src/generate.js
@@ -38,12 +38,7 @@ function fieldType(field, indent) {
 
     switch (field.type) {
         case 'list':
-            if (field.ofType.type === 'object' && !Object.keys(field.ofType.object).length) {
-                // If there are no selections we want an opaque object even if it is a list
-                flowType = `{||}`;
-            } else {
-                flowType = `Array<${fieldType(field.ofType, indent)}>`;
-            }
+            flowType = `Array<${fieldType(field.ofType, indent)}>`;
             break;
         case 'object':
             flowType = objectType(field.object, `${indent}${INDENT}`);