Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whatif devtest #86

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Whatif devtest #86

wants to merge 4 commits into from

Conversation

mivano
Copy link
Owner

@mivano mivano commented Nov 3, 2023

No description provided.

mivano added 4 commits October 15, 2023 00:02
@mivano
next try, using different logic
07c1e83
@mivano
Support for ModernUsageDetail
38c3c63
@mivano
Merge branch 'main' into whatif-devtest
87a5fcb 
# Conflicts:
#	src/Commands/WhatIf/DevTestWhatIfCommand.cs
#	src/CostApi/AzureCostApiRetriever.cs
#	src/CostApi/ICostRetriever.cs
@mivano
fix up
bf1c1d9
@stale Stale
Copy link

stale bot commented Feb 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 24, 2024
@mivano mivano removed the wontfix This will not be worked on label Feb 25, 2024
@stale Stale
Copy link

stale bot commented Apr 25, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 25, 2024
@mivano mivano removed the wontfix This will not be worked on label Apr 25, 2024
@stale Stale
Copy link

stale bot commented Jun 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 24, 2024
@mivano mivano removed the wontfix This will not be worked on label Jun 24, 2024
@stale Stale
Copy link

stale bot commented Aug 24, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 24, 2024
@mivano mivano removed the wontfix This will not be worked on label Aug 24, 2024
@stale Stale
Copy link

stale bot commented Oct 23, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 23, 2024
@mivano mivano removed the wontfix This will not be worked on label Oct 23, 2024
@mivano mivano requested a review from Copilot November 15, 2024 20:28
Copilot
Copilot AI reviewed Nov 15, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 20 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • src/OutputFormatters/JsonOutputFormatter.cs: Evaluated as low risk
  • src/CostApi/ICostRetriever.cs: Evaluated as low risk
  • src/OutputFormatters/CsvOutputFormatter.cs: Evaluated as low risk
  • src/OutputFormatters/MarkdownOutputFormatter.cs: Evaluated as low risk
  • src/OutputFormatters/TextOutputFormatter.cs: Evaluated as low risk
  • src/OutputFormatters/BaseOutputFormatter.cs: Evaluated as low risk
  • src/OutputFormatters/ConsoleOutputFormatter.cs: Evaluated as low risk
  • src/Program.cs: Evaluated as low risk
  • src/Commands/WhatIf/RegionWhatIfCommand.cs: Evaluated as low risk
  • src/CostApi/AzureCostApiRetriever.cs: Evaluated as low risk
  • src/Commands/WhatIf/DevTestWhatIfCommand.cs: Evaluated as low risk
  • src/CostApi/UsageDetail.cs: Evaluated as low risk
  • src/CostApi/UsageDetailsResponse.cs: Evaluated as low risk
  • src/CostApi/MeterDetailsResponse.cs: Evaluated as low risk
  • src/CostApi/PricingModelTypeConstant.cs: Evaluated as low risk
Comments skipped due to low confidence (2)

src/CostApi/ModernUsageProperties.cs:70

  • The property name exchangeRate should be ExchangeRate to follow PascalCase naming convention.
[JsonPropertyName("exchangeRate")]

src/CostApi/ModernUsageProperties.cs:115

  • The property name partnerEarnedCreditApplied should be PartnerEarnedCreditApplied to follow PascalCase naming convention.
[JsonPropertyName("partnerEarnedCreditApplied")]
@stale Stale
Copy link

stale bot commented Jan 14, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 14, 2025
@mivano mivano removed the wontfix This will not be worked on label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mivano