-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security and privacy policies for extension development #378
base: master
Are you sure you want to change the base?
Conversation
eb578e6
to
db948db
Compare
|
||
When a user uninstalls an _Extension Instance_, any data stored or processed by the extension related to that extension instance must be securely deleted. This includes: | ||
|
||
- User-generated data stored locally or remotely by the extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "remotely" part of this depends on whether we want to allow extensions to "eject" themselves (i.e. leave any managed resources that they created to be managed by the user themselves, when the extension is installed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a delicate topic. We still do not have a solution to enable contributors to "eject" their extension instance.
This is still a trade off situation between lifetime of access tokens and possibility of cleaning up mStudio resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't "ejecting" the default right now? Since the access tokens are revoked before the ExtensionInstanceRemovedFromContext
webhook is invoked, there's no possibility to clean up anything (at least, any mStudio resources), anyway.
When a user uninstalls an _Extension Instance_, any data stored or processed by the extension related to that extension instance must be securely deleted. This includes: | ||
|
||
- User-generated data stored locally or remotely by the extension. | ||
- Logs or backups created by the extension during its operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be unfeasible in some cases (for example, most extensions will manage all instances in a single deployment unit, meaning that backups and logs will contain data from all instances). Maybe change the wording to something like "should be asserted that backups and logs are deleted eventually"...? 🤔
|
||
When a user uninstalls an _Extension Instance_, any data stored or processed by the extension related to that extension instance must be securely deleted. This includes: | ||
|
||
- User-generated data stored locally or remotely by the extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a delicate topic. We still do not have a solution to enable contributors to "eject" their extension instance.
This is still a trade off situation between lifetime of access tokens and possibility of cleaning up mStudio resources.
Co-authored-by: freisenhauer <[email protected]> Signed-off-by: Martin Helmich <[email protected]>
This PR adds a security and a privacy policy for marketplace extension development.
Still missing: