let app and upgrade command accept an AppVersion uuid as target version #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
upgrades are included too |
martin-helmich
requested changes
Dec 5, 2024
| appVersionId, | ||
| ); | ||
| } else { | ||
| appVersion = await normalizeToAppVersionUuid( |
There was a problem hiding this comment.
Maybe build the "if it looks like a UUID, just use that"-logic directly into normalizeToAppVersionUuid? IIRC, all other normalize<whatever> functions that we have floating around work more or less similar, anyway.
Comment on lines
+118
to
+130
| } else if ( | ||
| this.flags["target-version"] && | ||
| validateUuid(this.flags["target-version"]) | ||
| ) { | ||
| targetAppVersion = await getAppVersionFromUuid( | ||
| this.apiClient, | ||
| currentApp.id, | ||
| this.flags["target-version"], | ||
| ); | ||
| } else if ( | ||
| this.flags["target-version"] && | ||
| !validateUuid(this.flags["target-version"]) | ||
| ) { |
There was a problem hiding this comment.
These ANDed conditions could be deconstructed to (maybe?) more readable nested conditions:
else if (this.flags["target-version"]) {
if (validateUuid(this.flags["target-version"])) {
// ...
} else {
// ...
}
} // ...
Also, the way how targetAppVersion is getting more and more complex, with more and more branches in this condition. I would suggest extracting the entire logic of populating targetAppVersion into a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is my implementation to realize the requested feature from #922