Remove unnecessary suspend_grad #1452
Open
+16
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRB suspends gradients on sample positions, ray and ray weight in the backward pass. I think this might be a leftover from the time we supported reparameterized PRB, where it was important to carefully detach the splatting position. Since the basic PRB integrator generally does not support differentiating sensor pose, I don't think this is needed anymore. Projective sampling anyway uses a separate base integrator class.
We came across this when trying to optimize a scale on the ray weight (e.g., an exposure parameter), which did not work due to this suspend_grad context.