fix: reduce unnecessary filesytem copies when spawning plugins #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjcasey
force-pushed
the
patrickjcasey/macos-plugins-fail-to-spawn
branch
from
13a65f6
to
0054e60
Compare
patrickjcasey
changed the title
|
Resolves #600 . |
j-lanson
requested changes
Nov 14, 2024
patrickjcasey
force-pushed
the
patrickjcasey/macos-plugins-fail-to-spawn
branch
from
0054e60
to
f2b0900
Compare
Screen.Recording.2024-11-14.at.1.18.27.PM.mov
|
On macOS, there are issues with overwriting a binary with a copy command, if it is already running, due to how the kernel caches binary signatures. To mitigate this, copying to a tempfile, then moving it resolves the issue
patrickjcasey
force-pushed
the
patrickjcasey/macos-plugins-fail-to-spawn
branch
from
f2b0900
to
7e00a49
Compare
j-lanson
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a video of this branch having two macOS
hc checkcommands work at the same time!Screen.Recording.2024-11-14.at.12.34.58.PM.mov
To trigger this bug on macOS, the following steps were the easiest way I could find to reliably trigger this
To avoid this issue,
hcnow checks thesha256of the source and destination before copying the files and skips the copy if the hashes are identical