fix: handling of plugin entrypoint string #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
force-pushed
the
jlanson/entrypoint-handling
branch
from
d6d0093
to
d90700b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code treated the
entrypointstring as aPathBuf, when in reality it could be a cmdline string with spaces and arguments.This PR updates the handling to reflect this, and also modifies the
retrieve_local_plugin()behavior to only copy the plugin entrypoint binary if it is a path. For instance, if the entrypoint started asdocker ..., we wouldn't copy thedockerbinary because does not exist as a path.Also updated the warning in
start_plugin()to warn if the binary component ofentrypointcannot be found withwhich.