Improved 'xtask' experience, removed old commands. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes some minimally useful commands from `xtask`, and also rewrites the `xtask` CLI and printing to be more consistent, more helpful, and easier to control. We now use `clap-verbosity-flag` to auto-handle verbosity through the `log` crate, and all printing (outside of auto-printing by `duct`) is handled through `log` and `env_logger`, with `clap-verbosity-flag` applying filtering based on CLI flags. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/xtask-improvements
branch
from
fb77724
to
f0a5a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some minimally useful commands from
xtask, and also rewrites thextaskCLI and printing to be more consistent, more helpful, and easier to control.We now use
clap-verbosity-flagto auto-handle verbosity through thelogcrate, and all printing (outside of auto-printing byduct) is handled throughlogandenv_logger, withclap-verbosity-flagapplying filtering based on CLI flags.