Diff parser bugfixes #577
Merged
Diff parser bugfixes #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh let me collapse Julian's test case commits down to one. |
This commit adds new test cases to the diff parser to catch some bugs we've identified. Signed-of-by: Julian Lanson <[email protected]>
alilleybrinker
force-pushed
the
570-bug-fix
branch
from
3452fd9
to
ae456f6
Compare
This fixes two parsing bugs in the diff parser. First, that sometimes stat blocks don't give numbers for lines added or removed, and instead just use the `-` character, which we now support. Second, that a patch can have a header with no chunks, which we also now support. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
570-bug-fix
branch
from
ae456f6
to
6373bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574, #570