Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Makes changes needed for affiliation plugin to run #558

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mchernicoff
Copy link
Contributor

Resolves #549

Updates affiliation plugin to run properly.

Because we have not yet implemented batching for queries, this PR adds temporary "local" functions to the git plugin, which do the same thing as existing async query functions but are not queries. It also adds new "batch" queries that call these local functions instead of relying on nested queries and can process more than one commit or contributor at once.

The code in the affiliation plugin has been updated to use these temporary queries instead of making looped calls to the regular queries. Once batching has been implemented, we can remove the temporary functions and change the execution code for affiliation back.

@mchernicoff mchernicoff added type: chore Clean up or management task. product: rust-sdk Relates to the Rust plugin SDK labels Nov 1, 2024
@mchernicoff mchernicoff added this to the 3.8.0 milestone Nov 1, 2024
@mchernicoff mchernicoff requested review from j-lanson and a team November 1, 2024 13:49
@mchernicoff mchernicoff self-assigned this Nov 1, 2024
plugins/affiliation/src/main.rs Show resolved Hide resolved
plugins/affiliation/src/main.rs Show resolved Hide resolved
plugins/affiliation/src/main.rs Show resolved Hide resolved
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michael!

@j-lanson j-lanson merged commit a6caa9a into main Nov 1, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the mchernicoff/validate-affiliation branch November 5, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: rust-sdk Relates to the Rust plugin SDK type: chore Clean up or management task.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Validate Affiliation plugin execution
2 participants