feat: Adds typo plugin #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchernicoff
added
type: enhancement
mchernicoff
requested review from
ninaagrawal and
j-lanson
and removed request for
a team
Closed
j-lanson
requested changes
Oct 30, 2024
|
Also remove |
mchernicoff
force-pushed
the
mchernicoff/typo-plugin
branch
3 times, most recently
from
a062841
to
f88eea1
Compare
j-lanson
requested changes
Oct 30, 2024
mchernicoff
force-pushed
the
mchernicoff/typo-plugin
branch
from
f88eea1
to
513c61d
Compare
j-lanson
requested changes
Oct 31, 2024
mchernicoff
force-pushed
the
mchernicoff/typo-plugin
branch
from
513c61d
to
59dc585
Compare
j-lanson
previously approved these changes
Oct 31, 2024
mchernicoff
force-pushed
the
mchernicoff/typo-plugin
branch
from
59dc585
to
dfd979d
Compare
j-lanson
approved these changes
Oct 31, 2024
mchernicoff
added
the
closed-because: duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #537
Most of the code in
plugins/typo/src/is a refactor of the code found inhipcheck/src/metrics/typo.rsandhipcheck/src/analysis/mod.rs. Some of the internal functions and types have been changed to support a simpler return type. This reflects the fact that he plugin's query does not use any information about what kind of typos were found for each flagged dependency, just which ones were flagged as typos.The plugin includes a
Typos.tomlfile for supporting JavaScript, copied fromconfig/Typos.toml.