feat: Support Spans and DateTimes in JSON Pointer injection #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstepanian
force-pushed
the
cstepanian/json_schema
branch
2 times, most recently
from
42e5348
to
76ecadc
Compare
cstepanian
changed the title
j-lanson
reviewed
Oct 29, 2024
j-lanson
reviewed
Oct 29, 2024
j-lanson
previously approved these changes
Oct 29, 2024
This commit enables JSON Pointers to read `jiff:Zoned` and `jiff::Span` from JSON objects marked as `date-time` and `duration`, respectively. The implementation expects an object with fields `format` and `data`. Currently, `format` must contain either "date-time" or "duration". `data` must include the data to be specially parsed.
cstepanian
force-pushed
the
cstepanian/json_schema
branch
from
76ecadc
to
0014e36
Compare
j-lanson
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #524
This PR adds initial support for reading type-annotated data from JSON objects returned by a Plugin.
Two new data types are supported:
jiff::Zonedandjiff::Span.This implementation expects the JSON to follow a particular format: the data will consist of a JSON object with two required fields,
formatanddata.formatmust contain a string that references a known format; this PR adds support for"date-time"and"duration". These names are adopted to match JSON Schema's naming.datamust contain the data; for both of these added data types, they are represented as JSON strings.References