chore: update analysis config to allow non-string values #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: bug
j-lanson
force-pushed
the
jlanson/fix-identity
branch
from
261626a
to
32b78e4
Compare
|
Looks good to me! |
patrickjcasey
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #539 .
Ran a simplified analysis with only identity analysis enabled.
identityispercent-thresholdwhich should be a float, but we only allow Strings currently. I updated the policy file definition to treat analysis config asHashMap<String, Value>instead.get_legacy()to check theMITRE_LEGACY_PLUGINSarray so "plugin-ified" analyses will use the proper policy-expr handling code.