fix: update target json desc from RootSchema to SchemaObject #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: bug
alilleybrinker
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #453 .
In the Issue, I suggested that we would need to switch our use of
schemars::SchemaObjecttoRootSchema, because just emitting theschema_for!(Target).schemaforTargetresults in a definition with#refs to objects that are not included in the document.I couldn't find a way through
schemarsnative to emit aSchemaObjectfrom a RootSchema with all the refs replaces with the definitions themselves, so I manually edited the resulting.jsonfile. I ensured that deserializing this to aschemars::SchemaObjectstill works.