Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds query sdk proc-macro #452

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: Adds query sdk proc-macro #452

merged 1 commit into from
Sep 27, 2024

Conversation

mchernicoff
Copy link
Contributor

Adds a Hipcheck SDK proc-macro that can mark functions to have a struct impl Query created.

@mchernicoff mchernicoff added type: enhancement New feature or request product: rust-sdk Relates to the Rust plugin SDK labels Sep 26, 2024
@mchernicoff mchernicoff added this to the 3.7.0 milestone Sep 26, 2024
@j-lanson
Copy link
Collaborator

I made sure that hipcheck-sdk-macros doesn't actually depend on hipcheck-sdk and removed it as a dependency.

j-lanson
j-lanson reviewed Sep 26, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
j-lanson
j-lanson requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that should be addressed before we merge

@mchernicoff mchernicoff force-pushed the jlanson/sdk-macro branch 3 times, most recently from 790da7a to 32f3d96 Compare September 27, 2024 14:10
patrickjcasey
patrickjcasey reviewed Sep 27, 2024
View reviewed changes
sdk/rust/src/lib.rs Outdated Show resolved Hide resolved
patrickjcasey
patrickjcasey reviewed Sep 27, 2024
View reviewed changes
sdk/rust/Cargo.toml Outdated Show resolved Hide resolved
@j-lanson j-lanson self-requested a review September 27, 2024 15:12
j-lanson
j-lanson requested changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

j-lanson
j-lanson approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michael, looks great!

@j-lanson j-lanson merged commit 39b28ab into main Sep 27, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the jlanson/sdk-macro branch November 5, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickjcasey patrickjcasey patrickjcasey left review comments

@j-lanson j-lanson j-lanson approved these changes

@alilleybrinker alilleybrinker Awaiting requested review from alilleybrinker

@cstepanian cstepanian Awaiting requested review from cstepanian

Assignees

@mchernicoff mchernicoff

@j-lanson j-lanson

Labels
product: rust-sdk Relates to the Rust plugin SDK type: enhancement New feature or request
Projects
Hipcheck Dev Roadmap
Status: Done
Hipcheck Product Roadmap
Status: Done
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mchernicoff @j-lanson @patrickjcasey