Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syscall.c #267

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from
Open

Update syscall.c #267

wants to merge 1 commit into from

Conversation

taiwoabe
Copy link

No description provided.

@taiwoabe
Copy link
Author

pull

Copy link

@echtwerner echtwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Change seems to be part of PR #264 upto #268.
In my opinion you should combine all changes into 1 PR, cause they are related and should be reviewed in once.
BTW I implemented the same function in october 2023, it seems to be natural to have the desire to get freepages and freemem.
But I believe since xv6-riscv is a learning OS, they want not to implement this changes into the source code. te
Anyway it would be good if the maintainer of this repo would close PR's which wont get accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants