Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: compat with pydantic v1 #102

Closed
wants to merge 1 commit into from
Closed

deps: compat with pydantic v1 #102

wants to merge 1 commit into from

Conversation

jean-malo
Copy link
Contributor

No description provided.

AntoineAtMistral
AntoineAtMistral approved these changes Jun 10, 2024
View reviewed changes
Copy link

@AntoineAtMistral AntoineAtMistral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit annoying I think, but I don't think of other ways except telling them to update to v2 😄

Bam4d
Bam4d requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@Bam4d Bam4d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jean-malo jean-malo marked this pull request as draft June 10, 2024 10:27
@jean-malo jean-malo closed this Jun 11, 2024
@jean-malo jean-malo deleted the deps/compat-pydantic-v1-0-4-1 branch June 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineAtMistral AntoineAtMistral AntoineAtMistral approved these changes

@Bam4d Bam4d Bam4d approved these changes

@fuegoio fuegoio Awaiting requested review from fuegoio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jean-malo @Bam4d @AntoineAtMistral