-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swedish stopwords #195
Conversation
Hello, thank you for the PR. Can you please explain some words to me? I don't speak Swedish but after translating those words I think some are suspicious and not a suitable for stopwords. Stopwordsaderton (Not a real stopword) |
Hi! I used the spaCy package's list of swedish stop words as my source, and i believe this list is widely used for Swedish language processing. |
Yes, I know other projects use a lot of stopwords. I always tried to use only the general ones without any meaning at all. I translated some as "eighteen" or "goodbye" which I would omit. But because I have no knowledge of Swedish language we can merge. Maybe someone improves it if needed. Can I ask you for the test too to make sure the language works with all component? |
I see, i've removed some stop words now that i belive were not as suitable. I have also added a test for the Swedish stemmer aswell. |
Can we merge, or is it something more that needs to be addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it is fine like this :)
2a7f201
to
5610367
Compare
Great contribution, good job @RobertMartinis! |
Adds Swedish stop words for the stemmer.